Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Mac: Keep the signing-related keychain unlocked #2927

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Build: Mac: Keep the signing-related keychain unlocked #2927

merged 1 commit into from
Oct 20, 2022

Conversation

hoffie
Copy link
Member

@hoffie hoffie commented Oct 19, 2022

Short description of changes
This fixes hanging Mac build runs in CI which got stuck as they required interactive unlocking of the keychain.
This issue only became appareant after the switch to universal builds as that made the build take longer than the re-lock interval.

CHANGELOG: Build: Mac: Keep the signing-related keychain unlocked

Context: Fixes an issue?
Fixes: #2925

Does this change need documentation? What needs to be documented and how?
No.

Status of this Pull Request
The fix has already been committed and tested successfully on @emlynmac's repo where I've manually modified the r3_9_1 tag to do so.

What is missing until this pull request can be merged?
Reviews.
(CI on this PR must not file, but it being successful does not prove anything either ;))

Please merge once reviews are completed.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

AUTOBUILD: Please build all targets

@hoffie
Build: Mac: Keep the signing-related keychain unlocked
10e3a2d 
This fixes hanging Mac build runs in CI which got stuck as they required
interactive unlocking of the keychain.
This issue only became appareant after the switch to universal builds as
that made the build take longer than the re-lock interval.

Fixes: jamulussoftware#2925
@hoffie hoffie added this to the Release 3.9.1 milestone Oct 19, 2022
@hoffie hoffie requested a review from pljones October 19, 2022 21:47
@hoffie hoffie requested a review from ann0see October 19, 2022 21:47
emlynmac
emlynmac approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@emlynmac emlynmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice; LGTM

@hoffie hoffie mentioned this pull request Oct 19, 2022
Closed
59 tasks
@ann0see
Copy link
Member

ann0see commented Oct 20, 2022

@daryu maybe you experienced something like this too? Could you please comment?

@pljones
Copy link
Collaborator

pljones commented Oct 20, 2022

One other comment: why did the build hang rather than fail? Do we know? Is that something that could have been prevented and made to fail with a useful error?

pljones
pljones approved these changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@pljones pljones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, it works. Subject to my other comment that's out of scope for this hot fix.

@hoffie
Copy link
Member Author

hoffie commented Oct 20, 2022

One other comment: why did the build hang rather than fail? Do we know? Is that something that could have been prevented and made to fail with a useful error?

As far as I have found, it's likely not a real hang, but rather waiting for activity in a graphical dialog box, which we'll never see in the CI which is only CI-based.

@pljones
Copy link
Collaborator

pljones commented Oct 20, 2022

One other comment: why did the build hang rather than fail? Do we know? Is that something that could have been prevented and made to fail with a useful error?

As far as I have found, it's likely not a real hang, but rather waiting for activity in a graphical dialog box, which we'll never see in the CI which is only CI-based.

That's what I was guessing, too. Is there any way to prevent it, or a tool that better understands automated CI?

@hoffie
Copy link
Member Author

hoffie commented Oct 20, 2022 •
edited
Loading

That's what I was guessing, too. Is there any way to prevent it, or a tool that better understands automated CI?

I don't think so. The most official way seems to be Xcode, which is purely graphical. codesign is the fall back and is implicitly used by macdeployqt. It's probably not codesign itself which generates the dialog box, but rather the system keychain integration. I don't know of any other tool.
https://stackoverflow.com/questions/20205162/user-interaction-is-not-allowed-trying-to-sign-an-osx-app-using-codesign

@ann0see
Copy link
Member

ann0see commented Oct 20, 2022

I remember suspecting something like that some time ago too. That was the Apple script invocation in create-dmg (GitHub fixed it on their side a while ago.)

@hoffie hoffie merged commit 86ce08a into jamulussoftware:master Oct 20, 2022
@hoffie hoffie deleted the autobuild/fix-mac-build-hang-keychain-relock branch October 30, 2022 22:08
@hoffie hoffie mentioned this pull request Nov 7, 2022
Open
@pljones pljones modified the milestones: Release 3.9.1, Release 3.10.0 Jul 29, 2023
@pljones
Copy link
Collaborator

pljones commented Jul 29, 2023

I think this actually didn't make the 3.9.1 cut. This is just looking at the merges since the r3_9_1 tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ann0see ann0see ann0see approved these changes

@emlynmac emlynmac emlynmac approved these changes

@pljones pljones pljones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Tracking
Status: Done
Milestone
Release 3.10.0
Development

Successfully merging this pull request may close these issues.

Mac: Signed release build process gets stuck during signing
4 participants
@hoffie @ann0see @pljones @emlynmac